(DONE) Data Logger#

Acquisition loop, left (sensors), right (a CSV file? Terminal/std::cout?). Sketch that in spaghetti style ⟶ reusable components!

Sensor config (by name). Vector of pairs (name: string, Sensor*) internally, but with a dedicated class around it to constrain the interface to what’s needed.
Acquisition loop class. Interval, left (sensor config), right (CSV/Terminal?).
Problem: decoupling ⟶ interface (eg. Sink)

Standup Records #

Structure: datalogger/CMakeLists.txt

Explain: TARGET_INCLUDE_DIRECTORIES() announces . PUBLIC to anyone who needs that node
void DataLogger::startLogging(uint16_t count = 0);, with 0 having the special meaning infinity ⟶ unification into one single method
Remove leftover DataLogger::getTime(). Defer implementation until we need timestamps
tests/logger-suite.cpp: don’t use SinkFile - test in terms of SinkMock

⟶ make SinkMock usable for that purpose
tests/sink-suite.cpp
- use SinkMock instead of SinkFile (like above)
- don’t use SensorConfig to create a SensorValues object - create it directly, inside the test (we’re not testing SensorConfig, only the sink)
  
  Best to create tests/sensor-values-suite.cpp to define the behavior of SensorValues
tests/sensor-config-suite.cpp
- Adding the same name three times should be an error (lets use throw runtime_error("...message here...") as an error handling replacement)
- Three sensors should lead to a measurement size (.size()) of 3
- …

Look over new tests
- logger_suite.LoggerBasicTest
- sensor_values_suite.*
- sensor_config_suite.basic
SensorConfig: check duplicates
- sensor_config_suite.duplicate_sensor
Outlook
- Data Logger: CSV Sink
- Data Logger: MQTT Sink

Modify the program bin/data-logger.cpp to compose itself out of prebuilt components.

Sensor config (by name).
Acquisition loop class. Interval, left (sensor config), right (CSV/Terminal?).
Problem: decoupling ⟶ interface (eg. Sink)

Look like a number of classes is in order …

SensorConfig. Holds the sensors, together with their names.
- void add(const std::string& name, Sensor*);
- Iteration over (name,sensor) pairs. Maybe a method const std::map<std::string, Sensor*> all(); that gives easy access to that iteration? See the current state of bin/data-logger.cpp for iteration.
SensorValues. Much like the SensorConfig, but with live values instead of sensors.
AcquisitionLoop.
- (Constructor). Parameters interval, n_iterations?
- void doit(); Nothing more.
A Sink hierarchy, starting at the interface Sink. (See the Sensor hierarchy for how interfaces are made.)
- The interface will have to have something like void write_measurements(const SensorValues&);
- The first implementation could be for testing only - MockingSink. That class simply stores the SensorValues that it receives in a std::vector that is used by the tests.